Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: Re-enable Node 5/OSX, Downgrade to npm@4 for Node 8/OSX #664

Merged
merged 2 commits into from Jun 5, 2017

Conversation

malept
Copy link
Member

@malept malept commented Jun 4, 2017

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (not applicable).
  • The changes have sufficient test coverage (not applicable).
  • The testsuite passes successfully on my local machine (not applicable).

Summarize your changes:

npm@5 (strangely, just on OSX) doesn't install modules correctly for some reason. Example:
https://travis-ci.org/electron-userland/electron-packager/jobs/239192709

Closes #598.

@malept malept changed the title Travis: Ignore Node 8/OSX instead of Node 5/OSX Travis: Re-enable Node 5/OSX, Downgrade to npm@4 for Node 8/OSX Jun 4, 2017
`npm@5` (strangely, just on OSX) doesn't install modules correctly for
some reason. Example:
https://travis-ci.org/electron-userland/electron-packager/jobs/239192709
@malept
Copy link
Member Author

malept commented Jun 5, 2017

The one AppVeyor error is just a network failure.

@malept malept merged commit 2e48d1d into master Jun 5, 2017
@malept malept deleted the disable-node-8-osx branch June 5, 2017 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant