fix: Ensuring process.env.NODE_ENV is always properly set (#246)

electron-userland · Jan 15, 2019 · fca5a0e · fca5a0e
1 parent a22d1a0
commit fca5a0e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/packages/electron-webpack/src/targets/BaseTarget.ts b/packages/electron-webpack/src/targets/BaseTarget.ts
@@ -108,7 +108,8 @@ function configureDevelopmentPlugins(configurator: WebpackConfigurator) {
   const plugins = configurator.plugins
   configurator.config.optimization!!.namedModules = true
   plugins.push(new DefinePlugin({
-    __static: `"${path.join(configurator.projectDir, "static").replace(/\\/g, "\\\\")}"`
+    __static: `"${path.join(configurator.projectDir, "static").replace(/\\/g, "\\\\")}"`,
+    "process.env.NODE_ENV": configurator.isProduction ? "\"production\"" : "\"development\""
   }))
 
   plugins.push(new HotModuleReplacementPlugin())

diff --git a/packages/electron-webpack/src/targets/RendererTarget.ts b/packages/electron-webpack/src/targets/RendererTarget.ts
@@ -86,13 +86,6 @@ export class BaseRendererTarget extends BaseTarget {
     configurator.debug("Add ExtractTextPlugin plugin")
     configurator.plugins.push(new MiniCssExtractPlugin({filename: `${configurator.type === "renderer-dll" ? "vendor" : "styles"}.css`}))
 
-    // https://github.com/electron-userland/electrify/issues/1
-    if (!configurator.isProduction) {
-      configurator.plugins.push(new DefinePlugin({
-        "process.env.NODE_ENV": "\"development\"",
-      }))
-    }
-
     await BaseTarget.prototype.configurePlugins.call(this, configurator)
   }
 }