This repository has been archived by the owner on Jun 5, 2019. It is now read-only.
Move electron-devtools-installer to prod deps #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick bugfix for something I'm doing next week. Merging this in immediately after a green build so I can get unblocked.
Reasoning for not waiting for review:
electron-devtools-installerwould have a easy technique to not throw errors in prod but also be a noop I.e. not ship itself. I'm coming up with a solution for this at the moment by exposing anafterCopyhook inelectron-devtools-installerto create a "fake" module at package time that fakes the installer API so your code will become noop