Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document deployment schedule #395

Closed
perry-mitchell opened this issue Nov 27, 2017 · 6 comments
Closed

Document deployment schedule #395

perry-mitchell opened this issue Nov 27, 2017 · 6 comments

Comments

@perry-mitchell
Copy link
Contributor

Hi! I'm unable to find any information regarding how often the electron apps list on the website is updated. Perhaps it would be good to mention this in the contribution documentation and/or the readme?

For instance, I submitted my application "Buttercup" 10 days ago and it hasn't appeared on the website yet, so I was just wondering what the average turn-around time is for updates to be pushed to the website.

Thanks!

@zeke zeke changed the title Deployment schedule Document deployment schedule Dec 14, 2017
@zeke
Copy link
Contributor

zeke commented Dec 14, 2017

Generally speaking, PRs merged here should end up on the website pretty quickly. The flow is like this:

  • PR is merged
  • A Heroku Scheduler process runs the electron-apps build and publishes to npm if any changes are present.
  • Greenkeeper picks up the new version of electron-apps and opens a PR on electronjs.org
  • A human reviews the website PR and merges
  • Commits to the website's master branch are auto-deployed to Heroku.

I have updated the title of this issue and will leave it open as a reminder to document the process and help set expectations. Alternatively, we could have a Probot bot that chimes in when the PR is closed and leaves a comment...

@whyboris
Copy link
Contributor

Looking at Releases - things were getting continuously updated (and perhaps some automation step broke and the updating was too frequent). But 17 days ago, that automation hasn't been turned on, or something else is at hand -- no new releases occurred in the last 17 days.

I suspect code maintainers know about this, but I thought to mention here (and not open up a new issue)

@zeke
Copy link
Contributor

zeke commented Jun 18, 2018

I was unaware, thanks for the comment. I will look into it this week, and I've created #681 as a reminder to set up alerts for these kind of failures.

@zeke
Copy link
Contributor

zeke commented Jun 18, 2018

The release wasn't working because GitHub's git tags and the npm release version had fallen out of sync.

This is now fixed, and the latest apps are now live on the site: electron/electronjs.org-old@59bff2f

I've also opened #684 which adds some documentation about the release schedule.

I've also configured a notification so we'll get early warnings about this kind of failure in the future: #681

@vladimiry
Copy link
Contributor

Hi @zeke, is the website publishing process got broken again? I can't seem to locate on the website an app that got merged 5 days ago.

@zeke
Copy link
Contributor

zeke commented Aug 6, 2018

@vladimiry investigating..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants