-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There are no errors when packing a folder although it does not exist. #141
Comments
@chenjunyu19 I'm assuming it has just made an empty ASAR file, I personally don't see an issue here. Semantically it is still accurate because the ASAR file has nothing inside it. I guess we could error out but the current behavior isn't a problem IMO |
Hello, I've encountered similar issues recently so I felt compelled to contribute my $.02. In a developer's world error messages are not only necessary but expected and appreciated. At least a warning in this case could save someone a lot of time tracking down a problem only to find out they mistyped the pack command or had a typo in a script. Trying to pack a folder that doesn't exist is an error, intended or not. Especially when using command line versions of an app "interactively" I think errors (or at a minimum a warning) is expected and appreciated. I learned recently there is something called "hidden errors" in the world of software development. I personally disagree with the entire concept of "hidden errors". I respect anyone's opinion that providing no error is accepted behavior; however, if there was an option to turn off hidden errors I would always have is set to true. I can't tell you how many hours I've wasted that I will never get back because of "hidden errors". If you ask to do something with a folder that does not exist that is an error IMHO because you did not verify the folder existed before making the request. Having said that, I can only ask.....what is the harm in providing an error or warning in this case? Would doing so cause the app to be dysfunctional or cause any negative consequences? I'm curious as to the reasons behind "hidden errors". Maybe there is a good reason that I'm just not grasping. Assuming there is a good reason for not providing an error there are still situations where errors are wanted, especially during development and testing. Maybe adding a "strict" or "verboseErrors" or "showAllErrors" type of option would be helpful? Thank you in advance for your time and consideration. |
Here is the demo GIF.
The text was updated successfully, but these errors were encountered: