-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
asar.extractFile is Sync #167
Comments
You can't with the current API, certainly. Given the ASAR format, how feasible is it to even implement? |
@malept You'd have to |
Humm... i see... |
We'd be happy to review a pull request to update the API docs for |
Cool! I'll look into that when I have some free time next week. |
@MarshallOfSound's explanation makes sense - but that leaves me wondering how Electron's Unless I'm crazy, I think I've used |
So... I just lost a couple minutes with this and thought it was probably a minor accident or something.
asar.extractFile is not returning a promise or using a callback.
I just checked out the imprint of the code and it seems you are calling disk.readFileSync.
is there a way to call extractFile Asynchronously?
Thanks
The text was updated successfully, but these errors were encountered: