Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop support for Node < 8 #170

Merged
merged 16 commits into from
Apr 27, 2019
Merged

feat: drop support for Node < 8 #170

merged 16 commits into from
Apr 27, 2019

Conversation

malept
Copy link
Member

@malept malept commented Apr 26, 2019

BREAKING CHANGE: drop support for versions of Node which are EOL'd as of 2019-04-30.

The commit messages should give a pretty clear idea of what happened in this branch.

Copy link
Contributor

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring.

@zcbenz
Copy link
Contributor

zcbenz commented Apr 26, 2019

I think we should release 2.0 for this change?

@zcbenz zcbenz mentioned this pull request Apr 26, 2019
@malept malept changed the title Drop support for Node < 8 chore: drop support for Node < 8 Apr 26, 2019
@malept
Copy link
Member Author

malept commented Apr 26, 2019

Hopefully #171 will cause this to happen automatically 😄 (assuming the BREAKING CHANGE is added to the squashed commit message)

@malept malept changed the title chore: drop support for Node < 8 feat: drop support for Node < 8 Apr 27, 2019
@malept malept merged commit 8a03eae into master Apr 27, 2019
@malept malept deleted the node-8 branch April 27, 2019 04:14
@electron-bot
Copy link

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants