Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't monkeypatch fs with promisified versions #176

Merged
merged 2 commits into from
Apr 29, 2019
Merged

fix: don't monkeypatch fs with promisified versions #176

merged 2 commits into from
Apr 29, 2019

Conversation

malept
Copy link
Member

@malept malept commented Apr 29, 2019

Discovered this bug when trying to upgrade Electron Packager. The resolve module never completes when fs.readFile is monkeypatched.

@malept malept merged commit 319dd81 into master Apr 29, 2019
@malept malept deleted the no-monkeypatching-fs branch April 29, 2019 17:22
@electron-bot
Copy link

🎉 This PR is included in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@malept @electron-bot