feat: add file hashes to asar header #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malept
reviewed
Aug 30, 2021
Ah didn't realize the README actually documented this format clearly, updated the README 👍 |
nornagon
suggested changes
Sep 7, 2021
MarshallOfSound
force-pushed
the
add-file-hash-to-header
branch
from
109a5e5
to
927723a
Compare
nornagon
reviewed
Sep 8, 2021
nornagon
reviewed
Sep 8, 2021
nornagon
reviewed
Sep 8, 2021
nornagon
reviewed
Sep 8, 2021
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds a new public API for
getRawHeaderto allow callers to determine the SHA of the header for integrity purposes. This is fully backwards compatible in that no code expects this field to be populated in this module as it is intended to be used by consumers rather than this module directly.