fix: properly handle rejections on createPackageWithOptions

[erikian]

Minor cleanup: asar.createPackageWithOptions doesn't take a fourth argument, so it's safe to remove it

[malept]

Shouldn't the promise be handled?

[erikian]

Probably, but unless we output a more useful error message or do something else on rejections, moving the callback we had to a .catch will do basically the same an unhandled rejection already does: output the error message, the stack and exit with a non-zero code.

[malept]

I think Node.js also outputs UnhandledRejection, which isn't ideal.

[erikian]

Good point, I was testing in node 16 which doesn't show that message anymore 😅

I've changed error.stack to just error as error.stack seems non-standard. They both show the error message and stack for me (node 16 on Windows), and as a bonus, the error output has some formatting now.

[continuous-auth]

🎉 This PR is included in version 3.2.5 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀