Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filenames which have multibyte characters in them cause corrupt asar files #74

Closed
DanielDignam opened this issue Jul 12, 2016 · 0 comments · Fixed by #86
Closed

Filenames which have multibyte characters in them cause corrupt asar files #74

DanielDignam opened this issue Jul 12, 2016 · 0 comments · Fixed by #86

Comments

@DanielDignam
Copy link

Simple example, creates a directory with one file in it which has a mulitbyte character filename. The pack apparently works, but list gives an error, and unpack fails silently

mkdir g
echo a >  g\女の子.txt
node ..\node_modules\asar\bin\asar  pack g t.asar
node ..\node_modules\asar\bin\asar  list t.asar
undefined:1
{"files":{"女の子.txt":{"size":8,"offset":
                                       ^
SyntaxError: Unexpected end of input
    at Object.parse (native)
    at Object.module.exports.readArchiveHeaderSync (C:\repos\eagle-print\desktop\node_modules\asar\lib\disk.js:97:20)
    at Object.module.exports.readFilesystemSync (C:\repos\eagle-print\desktop\node_modules\asar\lib\disk.js:105:21)
    at Object.module.exports.listPackage (C:\repos\eagle-print\desktop\node_modules\asar\lib\asar.js:141:17)
    at Command.<anonymous> (C:\repos\eagle-print\desktop\node_modules\asar\bin\asar:42:23)
    at Command.listener (C:\repos\eagle-print\desktop\node_modules\asar\node_modules\commander\index.js:249:8)
    at emitTwo (events.js:87:13)
    at Command.emit (events.js:172:7)
    at Command.parseArgs (C:\repos\eagle-print\desktop\node_modules\asar\node_modules\commander\index.js:480:12)
    at Command.parse (C:\repos\eagle-print\desktop\node_modules\asar\node_modules\commander\index.js:372:21)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant