Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

[Unity] more elegant solution to unity detection #197

Closed
wants to merge 1 commit into from

Conversation

markbaas
Copy link

A proposed fix for electron/electron#465

@markbaas
Copy link
Author

I couldn't test it as I wasn't able to compile electron (tried all weekend).

@anaisbetts
Copy link
Contributor

@markbaas The problem is that this isn't correct. Even if I'm running Xubuntu (i.e. not using Unity), we still need to operate as if we're under Ubuntu-style notifications

@markbaas
Copy link
Author

Hmm in that case the fix just may be adding "/usr/lib/[arch]-linux-gnu/" to the path.

@anaisbetts
Copy link
Contributor

@markbaas Yeah, we'll have to end up checking both places since not every distro will end up doing this right away. I'd certainly love to find a more thorough solution though

@deepak1556
Copy link
Contributor

Cant we just try a dlopen with RTLD_NOLOAD to check for libunity instead ? chrome seems to be doing the same thing https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/libgtk2ui/unity_service.cc&sq=package:chromium&l=73&rcl=1455582456

@anaisbetts
Copy link
Contributor

@deepak1556 This would solve the path issue, yeah - good idea

@3v1n0
Copy link
Contributor

3v1n0 commented Apr 12, 2016

Looks good, but XDG_CURRENT_DESKTOP has to be handled as a :-separated list.

@anaisbetts
Copy link
Contributor

I mentioned this earlier, but this isn't correct sadly - people using non-Unity DEs still have Unity's patched notifier, so they will get message boxes

@anaisbetts
Copy link
Contributor

Thanks for having a go at this @markbaas, but it looks like we found a better way to do this in #210 that should fix the bug

@anaisbetts anaisbetts closed this Apr 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants