Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Chocolatey On Windows? #220

Closed
dsanders11 opened this issue Oct 28, 2020 · 0 comments · Fixed by #391
Closed

Drop Chocolatey On Windows? #220

dsanders11 opened this issue Oct 28, 2020 · 0 comments · Fixed by #391
Labels
✨ enhancement New feature or request windows

Comments

@dsanders11
Copy link
Member

dsanders11 commented Oct 28, 2020

It would be nice to drop Chocolatey on Windows - that was an unpleasant first part of setting up build-tools on Windows. Since one of the build-tools design philosophies is to encapsulate rather than pollute the global namespace it kind of works against that (although I understand why it was necessary). In my own personal experience it also unnecessarily ended up installing an extra copy of Python - I already had one but the dependency check couldn't find it for some reason despite it being on the path. Chocolatey is also non-trivial to fully uninstall, which is another reason I'm not a fan of using it if it can be avoided.

As of the time of this writing, depot_tools bootstraps Python on Windows when gclient is used, meaning it really isn't necessary to use Chocolatey to install it. The only tricky thing there is it won't be on the path for running scripts in Electron's package.json, but there's already issues there where a depot_tools environment is needed to run some of those scripts anyway (see #179). Perhaps a solution like e npx <script> can be used to work around those issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant