Add categories to apps #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Can you add a test to human-data.js that ensures every app has a category, and that the category is one that we've defined/allowed? We should probably also document the categories in https://github.com/electron/electron-apps/blob/master/contributing.md#adding-your-app |
added 3 commits
July 12, 2017 09:50
Also, documented category in contributing and added it to the wizard. Also fixed broken categories on some apps.
|
@zeke I added the tests, documentation and I also updated the wizard to ask for a category. |
added 2 commits
July 12, 2017 10:07
This was referenced Jul 12, 2017
Closed
|
Nice. I created a followup issue at electron/electronjs.org-old#759 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds categories to apps so that we can eventually show apps by category.
The following was also done: