fix: ensure that CFBundleExecutable and friends are correct for helper apps #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
force-pushed
the
fix-6-bundle
branch
from
9c4a9fc
to
65c54cc
Compare
assuming tests pass
Codecov Report
@@ Coverage Diff @@
## master #1046 +/- ##
======================================
Coverage 100% 100%
======================================
Files 14 14
Lines 687 689 +2
======================================
+ Hits 687 689 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CFBundleExecutablevalue was wrong as we were overwritingthis.helperPlistfor every helper. Now we don't and now the values are correct. There are even tests and stuffFixes #1045.