Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use console.info for info logging #1531

Conversation

bilalswiftsolutions
Copy link
Contributor

@bilalswiftsolutions bilalswiftsolutions commented Jul 7, 2023

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

@bilalswiftsolutions bilalswiftsolutions requested a review from a team as a code owner July 7, 2023 14:16
@welcome
Copy link

welcome bot commented Jul 7, 2023

Thanks for opening a pull request!

Here are some highlighted action items that will help get it across the finish line, from the
pull request guidelines:

  • Follow the JavaScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes in NEWS.md and other docs.
  • Include tests when adding/changing behavior.

Development and triage is community-driven, so please be patient and we will get back to you as soon as we can.

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #1531 (43ed30b) into main (af334e3) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 43ed30b differs from pull request most recent head af42d19. Consider uploading reports for the commit af42d19 to get more accurate results

@@           Coverage Diff           @@
##             main    #1531   +/-   ##
=======================================
  Coverage   95.58%   95.58%           
=======================================
  Files          15       15           
  Lines         793      793           
=======================================
  Hits          758      758           
  Misses         35       35           
Impacted Files Coverage Δ
src/common.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dsanders11 dsanders11 changed the title Update common.js chore: use console.info for info logging Oct 25, 2023
@dsanders11 dsanders11 merged commit e73c731 into electron:main Oct 25, 2023
2 checks passed
@welcome
Copy link

welcome bot commented Oct 25, 2023

Thanks for your contribution! 🎉

Copy link

🎉 This PR is included in version 18.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants