fix: add std=c++17 flag for e20+

electron · Jul 6, 2022 · 979361d · 979361d
1 parent 20107a8
commit 979361d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/clang-fetcher.ts b/src/clang-fetcher.ts
@@ -2,6 +2,7 @@ import * as cp from 'child_process';
 import debug from 'debug';
 import * as fs from 'fs-extra';
 import * as path from 'path';
+import semver from 'semver';
 import * as tar from 'tar';
 import * as zlib from 'zlib';
 import { ELECTRON_GYP_DIR } from './constants';
@@ -36,10 +37,14 @@ export async function getClangEnvironmentVars(electronVersion: string, targetArc
   const clangDownloadDir = await downloadClangVersion(electronVersion);
 
   const clangDir = path.resolve(clangDownloadDir, 'bin');
+  const cxxflags = [];
   const clangArgs: string[] = [];
   if (process.platform === 'darwin') {
     clangArgs.push('-isysroot', getSDKRoot());
   }
+  if (semver.major(electronVersion) >= 20) {
+    cxxflags.push('-std=c++17');
+  }
 
   const gypArgs = [];
   if (process.platform === 'win32') {
@@ -56,6 +61,8 @@ export async function getClangEnvironmentVars(electronVersion: string, targetArc
     env: {
       CC: `"${path.resolve(clangDir, 'clang')}" ${clangArgs.join(' ')}`,
       CXX: `"${path.resolve(clangDir, 'clang++')}" ${clangArgs.join(' ')}`,
+      CFLAGS: `${cxxflags.join(' ')}`,
+      CXXFLAGS: `${cxxflags.join(' ')}`
     },
     args: gypArgs,
   }

diff --git a/src/module-type/node-gyp.ts b/src/module-type/node-gyp.ts
@@ -89,6 +89,10 @@ export class NodeGyp extends NativeModule {
     let env: Record<string, string | undefined>;
     const extraNodeGypArgs: string[] = [];
 
+    if (semver.major(this.rebuilder.electronVersion) >= 20) {
+      process.env.CXXFLAGS = '-std=c++17';
+    }
+
     if (this.rebuilder.useElectronClang) {
       env = { ...process.env };
       const { env: clangEnv, args: clangArgs } = await getClangEnvironmentVars(this.rebuilder.electronVersion, this.rebuilder.arch);