Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Add a electron-packager afterCopy hook to the exports #120

Closed
wants to merge 1 commit into from

Conversation

MarshallOfSound
Copy link
Member

This adds a createPackagerCopyHook function to the exports of electron-rebuild.

Basic usage is like so

packager({
  ...
  afterCopy: [createPackagerCopyHook()]
  ...
})

You can add custom options like so

createPackagerCopyHook(distUrl, ignoreDev, ignoreOpt, preGypFix, verbose)

This makes rebuilding modules for distribution so much easier as you don't have to worry about your node_modules folder being built for a different arch after you run your packager.

Fixes #99

@MarshallOfSound MarshallOfSound changed the title Add a electron-packager afterCopy hook to the exports WIP Add a electron-packager afterCopy hook to the exports Oct 22, 2016
@anaisbetts
Copy link
Contributor

@MarshallOfSound Do we still want to do this?

@MarshallOfSound
Copy link
Member Author

Nope, the newly exported function is already basically in the required form for an afterCopy hook. This has been superceded 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants