Fix disabling accelerators #12449
Merged
Fix disabling accelerators #12449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
approved these changes
Mar 27, 2018
|
Can we add a test to ensure this doesn't happen again? 🤔 |
|
per discussion with @MarshallOfSound, there's no real easy way to test this, sadly. |
|
An error occurred while attempting to backport this PR to "1-8-x", you will need to perform this backport manually |
|
We have automatically backported this PR to "2-0-x", please check out #12455 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12384.
We checked that
(command.accelerator)instead of that(command.accelerator != null); empty strings are falsy so this removed the ability to disable accelerators by setting them to''. This reverts that.