Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make single instance the default #12763

Open
timfish opened this issue May 1, 2018 · 1 comment
Open

Make single instance the default #12763

timfish opened this issue May 1, 2018 · 1 comment
Assignees
Labels

Comments

@timfish
Copy link
Contributor

timfish commented May 1, 2018

Running multiple instances of Electron is generally a bad idea and not really supported with the default configuration. Some renderer features don't work in this scenario (localStorage, IndexedDb, persisted sessions?) and this is not documented and so I'm guessing not tested for regressions either.

This would be a significant breaking change but in the spirit of guiding developers in the right direction it might be worth it.

Related to @MarshallOfSound's New event for makeSingleInstance.

@MarshallOfSound MarshallOfSound self-assigned this May 2, 2018
@MarshallOfSound MarshallOfSound added the semver/major incompatible API changes label May 2, 2018
@robatwilliams
Copy link

There also seems to be an issue with caching - I have reports that once an instance is running, subsequent launched instances fetch all network resources from the server rather than the cache.

I think the default should be to disallow doing unsupported things, especially if those are easily/accidentally done and on the face of it appear to work but with underlying issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants