Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add deprecate.property() #13101

Merged
merged 3 commits into from
May 29, 2018
Merged

feat: add deprecate.property() #13101

merged 3 commits into from
May 29, 2018

Conversation

ckerr
Copy link
Member

@ckerr ckerr commented May 29, 2018

Does what it says on the tin.

  • re-add deprecate.property()
  • add a property setter
  • add getter & setter tests
  • test to see if deprecated property is set when deprecate.property() is called

This is in preparation for planned object property deprecations in 3.0, e.g. blinkFeatures -> enaleBlinkFeatures

This eliminates copy-and-paste repetition for each deprecated property (example) but is a little more heavyweight, so I'd like a second opinion on this replacement.

@ckerr ckerr requested review from codebytere and a team May 29, 2018 14:05
@ckerr ckerr merged commit d907f43 into master May 29, 2018
@ckerr ckerr deleted the deprecate-property branch May 29, 2018 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants