Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: disable node options in node submodule #13311

Merged
merged 1 commit into from
Jun 20, 2018

Conversation

gnahzak
Copy link
Contributor

@gnahzak gnahzak commented Jun 19, 2018

Fix for issue #12695: starting Electron with Node options (export NODE_OPTIONS=--max-old-space-size=4096) resulted in a segfault. This was originally caused by calling node::Init() with a null pointer for argv, which occurs when NODE_WITHOUT_NODE_OPTIONS is undefined. We attempted defining NODE_WITHOUT_NODE_OPTIONS in electron.gyp but the definition did not propagate, so we defined it in node.gyp instead so we ended up changing common.gypi to introduce the definition for node compilation.

Fix coded with @sethlu, with the help of @codebytere @nitsakh @groundwater and @nornagon.

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • commit messages or PR title follow semantic commit guidelines

@gnahzak gnahzak requested a review from a team June 19, 2018 21:51
@welcome
Copy link

welcome bot commented Jun 19, 2018

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix, OR prefix at least one of your commit messages.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@sethlu sethlu force-pushed the electron-disable-node-options branch from 11ad1a3 to 6699acc Compare June 19, 2018 22:33
@MarshallOfSound MarshallOfSound merged commit 951aa83 into master Jun 20, 2018
@welcome
Copy link

welcome bot commented Jun 20, 2018

Congrats on merging your first pull request! 🎉🎉🎉

@MarshallOfSound MarshallOfSound deleted the electron-disable-node-options branch June 20, 2018 03:08
@MarshallOfSound
Copy link
Member

/trop run backport

@trop
Copy link
Contributor

trop bot commented Jun 20, 2018

The backport process for this PR has been manually initiated, here we go! :D

@MarshallOfSound
Copy link
Member

/trop run backport-to 2-0-x

@trop
Copy link
Contributor

trop bot commented Jun 20, 2018

We have automatically backported this PR to "3-0-x", please check out #13323

@trop trop bot removed the target/3-0-x label Jun 20, 2018
@trop
Copy link
Contributor

trop bot commented Jun 20, 2018

The backport process for this PR has been manually initiated, sending your 1's and 0's to "2-0-x" here we go! :D

@trop
Copy link
Contributor

trop bot commented Jun 20, 2018

We have automatically backported this PR to "2-0-x", please check out #13324

@trop trop bot added the merged/2-0-x label Jun 20, 2018
@electron electron deleted a comment from senn412 Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants