-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: disable node options in node submodule #13311
Conversation
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix, OR prefix at least one of your commit messages. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
11ad1a3
to
6699acc
Compare
Congrats on merging your first pull request! 🎉🎉🎉 |
/trop run backport |
The backport process for this PR has been manually initiated, here we go! :D |
/trop run backport-to 2-0-x |
We have automatically backported this PR to "3-0-x", please check out #13323 |
The backport process for this PR has been manually initiated, sending your 1's and 0's to "2-0-x" here we go! :D |
We have automatically backported this PR to "2-0-x", please check out #13324 |
Fix for issue #12695: starting Electron with Node options (
export NODE_OPTIONS=--max-old-space-size=4096
) resulted in a segfault. This was originally caused by callingnode::Init()
with a null pointer forargv
, which occurs whenNODE_WITHOUT_NODE_OPTIONS
is undefined. We attempted definingNODE_WITHOUT_NODE_OPTIONS
inelectron.gyp
but the definition did not propagate,so we defined it inso we ended up changingnode.gyp
insteadcommon.gypi
to introduce the definition for node compilation.Fix coded with @sethlu, with the help of @codebytere @nitsakh @groundwater and @nornagon.
Checklist
npm test
passes