[WIP] refactor: (Part I) make the ownership of URLRequestContextGetter more clear #13956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Accepts a factory class that can customize the creation of URLRequestContext * Use a separate request context for media which is derived from the default * Notify URLRequestContextGetter observers and cleanup on IO thread * Move most of brightray net/ classes into atom net/
deepak1556
force-pushed
the
request_context_refactor
branch
2 times, most recently
from
4db1bbf
to
8b04587
Compare
* Allows to use the default handler from content/ for http{s}, ws{s} schemes.
* Removes the storage of job factory in URLRequestContextGetter.
deepak1556
force-pushed
the
request_context_refactor
branch
from
8b04587
to
3acf3fa
Compare
3 tasks
MarshallOfSound
approved these changes
Aug 13, 2018
|
CI failures are known flakes on master 👍 Merging in as per discussion with @ckerr and @codebytere |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were relying on reference counting and cleaning up network code on the IO thread, this doesn't really work well and caused use-after-free. In this new mode, the class that owns URLRequestContextGetter finishes network cleanup and destroys itself on the IO thread. This also allowed to create multiple request context getters with custom URLRequestContext, the plan is to separate the request context for media and also add a switch to create URLRequestContext based on the network service from chromium in follow up PR.
Fixes #13686
Checklist
npm testpasses