chore: refactor context isolation spec #14394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spec/api-browser-window-spec.js
Outdated
| show: false, | ||
| webPreferences: { | ||
| contextIsolation: true, | ||
| preload: path.join(fixtures, 'api', 'isolated-preload.js') | ||
| } | ||
| }) | ||
| if (ws != null) ws.destroy() |
There was a problem hiding this comment.
It is better to keep this.
The afterEach hook won't be called if a test fails, and a window will be leaked.
deepak1556
force-pushed
the
context_isolation_spec_patch
branch
from
97e78c9
to
3b1fb22
Compare
|
@alexeykuzmin have made the changes, thanks! |
alexeykuzmin
approved these changes
Aug 31, 2018
MarshallOfSound
approved these changes
Aug 31, 2018
|
No Release Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #14346
Checklist
npm testpassesRelease Notes
Notes: no-notes