-
Notifications
You must be signed in to change notification settings - Fork 15.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS Mojave: Unclickable region in windows with "hiddenInset" title bar #14529
Comments
/cc @MarshallOfSound (I think you might be looking into Mojave issues?) |
It appears that the unclickable region is where the title would be if the window had a standard title bar. In the gif below there are two stacked windows. The rear window has a standard title bar, and the front window has a You can see that the unclickable area of the front window is the same size as the |
Setting the title to an empty string helps, but doesn't totally fix the problem. There's still a small unclickable region about the size of a single character. |
This doesn't seem like a workable solution considering that title is reflected in all sorts of other areas in the OS? CMD+Tab / Window menu etc? |
It's a workaround, not a solution. YMMV
I believe CMD+Tab displays the app name ( |
If it helps we're running Electron |
I'm seeing this issue also in https://marketplace.visualstudio.com/items?itemName=lehni.vscode-titlebar-less-macos |
This issue still exists in |
This would block microsoft/vscode#12377 in VSCode. |
This definitely seems to be an active problem, I am even having problems with input elements not working correctly in the top region when Any chance of the workaround developed by @knopp in microsoft/vscode#12377 (comment) making it into Electron? |
We are experiencing what I believe are additional side effects coming from the same bug. I have described them in hiddenInset breaks mouse interactions in the first 38px of the window. |
Could this issue be prioritized higher please? @codebytere @MarshallOfSound Attempting to work around this issue by setting the title to an empty string has all sorts of weird consequences:
And using a titlebar can really hinder the user experience for some apps, as they would look more like a website wrapped in an Electron shell with a quick script rather than something that's supposed to integrate much better with the OS. |
This is currently expected and unfixable behavior. The good news is there is an easy workaround. You can use the const w = new BrowserWindow({
frame: false,
titleBarStyle: 'hidden',
trafficLightPosition: {
x: 14,
y: 22,
}
}); The |
@MarshallOfSound that seems to work perfectly for me, thanks! Are there any drawbacks in removing the titlebar this way over via setting "hiddenInset"? If there aren't shouldn't Electron just execute the code you provided when the "hiddenInset" value is set? P.S. The precise coordinates at which the traffic lights get positioned with "hiddenInset" seems to be |
No drawbacks that I'm aware of, it's functionally different and is more likely to have some strange bugs. E.g. Historically we've had to work around edge cases with fullscreen mode and such, but in general it's a perfectly reasonable replacement. We might flip the implementation for
Hm, I pulled those numbers from what I assume is a reliable source 🤔 Where did you get |
Trial and error when comparing before and after screenshots. Where does that other coordinate come from? |
@fabiospampinato @MarshallOfSound perhaps you are both on different versions of macOS? |
Expected Behavior
Clicking any region of the window should activate the element under the cursor.
Actual behavior
A small region in the top-center of the window isn't clickable.
To Reproduce
Screenshots
![mojave](https://user-images.githubusercontent.com/5355/45313784-d51d6880-b4fd-11e8-9de8-1420b69cda69.gif)
macOS Mojave 10.14 Beta (18A384a)
👎macOS High Sierra 10.13.6
👍Additional Information
![screen shot 2018-09-10 at 1 36 50 pm](https://user-images.githubusercontent.com/5355/45314127-f599f280-b4fe-11e8-9296-a6dc43018409.png)
This issue impacts any application with critical navigation elements on the top of the page. For us (Basecamp 3), the "Hey!" menu is very difficult to click:
<notch-joke>
</notch-joke>
It's likely that Mojave will be released this week during the Apple Special Event on September 12.
The text was updated successfully, but these errors were encountered: