Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: AFP info for general public #14650

Merged
merged 5 commits into from
Sep 18, 2018
Merged

chore: AFP info for general public #14650

merged 5 commits into from
Sep 18, 2018

Conversation

sofianguy
Copy link
Contributor

@sofianguy sofianguy commented Sep 17, 2018

Description of Change

Migrating App Feedback Program info from the maintainers repo. This will be linked in the upcoming 3.0.0 blog post.

cc @ckerr

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines
Release Notes

Notes: no-notes

@sofianguy sofianguy requested review from a team and ckerr September 17, 2018 17:41
@MarshallOfSound
Copy link
Member

@sofianguy If we put this at the top level it won't end up on the website, where-as if we put it in tutorials or something it will auto-deploy to the site afaik.

https://github.com/electron/electron/tree/master/docs/tutorial

Maybe that would be a better home if we want this on the website?

@sofianguy
Copy link
Contributor Author

@MarshallOfSound I do want to put it on the website at some point. I spoke to Zeke briefly about where to put it on the website. For now that's undecided, so I think it's okay to leave it here for public linking purposes.

@MarshallOfSound
Copy link
Member

Sounds good.

If the plan is to link to it and move it later we should ensure the link points to the exact commit it lands on, not just master. Otherwise we'll move it and all the links will break

@sofianguy
Copy link
Contributor Author

@MarshallOfSound good point!

@codebytere -- link to exact commit for blog post

app-feedback-program.md Outdated Show resolved Hide resolved
app-feedback-program.md Outdated Show resolved Hide resolved
app-feedback-program.md Outdated Show resolved Hide resolved
@ckerr
Copy link
Member

ckerr commented Sep 18, 2018

Sam's got a good point -- even if this is an interim spot, we should put it someplace where at least we can put a redirect in the future.

For that reason, 👍 for moving this into docs/tutorials instead of the top-level

@codebytere codebytere changed the title migrate AFP info from maintainers chore: migrate AFP info from maintainers Sep 18, 2018
@groundwater
Copy link
Contributor

A few quick thoughts

  1. people don’t know about slack
  2. we won't necessarily admit everyone who applies
  3. we can prob skip the technical details e.g. 10k UH

I think we should just say we have a program, we use it to help prioritize work and get applications upgraded to the next stable as soon as possible. There’s an expectation of attending weekly status meetings, and people can inquire at info@electronjs.org

The details of our next cycle may change based on feedback from the last run, so I think we can just discuss the problem the AFP is trying to solve, and the approximate commitment required by the apps in the program.

I think on big change will be that for 4.0 we will be prioritizing apps who are closer to the next big hurdle, likely decided by user-count. That is, an app close to shipping to their next 1M users will be prioritized vs. an app far from shipping.

@sofianguy sofianguy requested a review from a team September 18, 2018 16:54
@sofianguy
Copy link
Contributor Author

@groundwater Ok. The details will remain in the maintainers repo.

@ckerr can you copy-edit my new changes please?

@sofianguy sofianguy changed the title chore: migrate AFP info from maintainers chore: AFP info for general public Sep 18, 2018
@@ -0,0 +1,2 @@
# Electron App Feedback Program
Electron is working on building a streamlined release process and having faster releases. To help with that, we have the App Feedback Program for large-scale Electron apps to report app-specific blockers to the Electron team. We use this program to help us prioritize work and get applications upgraded to the next stable release as soon as possible. There are a few requirements we expect from participants, such as attending weekly check-in meetings. If you are interested or have questions, please send us a message at info@electronjs.org.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short, friendly, and to the point. ❤️

Minor:

  • I'd make explicit that we'd like the reported issues to be on betas. Possible rewording: "for large-scale Electron apps to test our beta releases and report..."

  • s/app-specific blockers/app-specific issues/

  • s/weekly check-in meetings/short, online weekly check-ins/

@ckerr
Copy link
Member

ckerr commented Sep 18, 2018

3.0.0 is blocked on this, and it's a docs-only PR.

  • electron-lint failure appears to be unrelated; mentioned to @jkleinsc in #ci channel

  • electron-osx-testing is queued behind 11 tasks. Since this PR only adds a new .md file, I'm going to bypass that.

@ckerr ckerr merged commit ec125b7 into master Sep 18, 2018
@release-clerk
Copy link

release-clerk bot commented Sep 18, 2018

No Release Notes

@ckerr ckerr deleted the sofia-add-AFP-info branch September 18, 2018 18:13
@trop
Copy link
Contributor

trop bot commented Sep 18, 2018

We have automatically backported this PR to "3-0-x", please check out #14673

@trop trop bot added merged/3-0-x and removed target/3-0-x labels Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants