Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix breakpad symbols generation #14981

Merged
merged 1 commit into from
Oct 5, 2018
Merged

ci: fix breakpad symbols generation #14981

merged 1 commit into from
Oct 5, 2018

Conversation

alexeykuzmin
Copy link
Contributor

Description of Change

zip-symbols.py fails because it can't find an Electron build folder, e.g. here https://github.visualstudio.com/electron/_build/results?buildId=13298&view=logs

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines
Release Notes

Notes: no notes

@alexeykuzmin alexeykuzmin requested review from jkleinsc and a team October 5, 2018 09:12
@alexeykuzmin
Copy link
Contributor Author

alexeykuzmin commented Oct 5, 2018 •
edited

Windows CI builds are fine, because they set ELECTRON_OUT_DIR=Default globally.

@alexeykuzmin alexeykuzmin changed the title ci: fix breakpad symbols generation aci: fix breakpad symbols generation Oct 5, 2018
@alexeykuzmin alexeykuzmin changed the title aci: fix breakpad symbols generation ci: fix breakpad symbols generation Oct 5, 2018
jkleinsc
jkleinsc approved these changes Oct 5, 2018
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexeykuzmin
Copy link
Contributor Author

electron-osx-testing failure is irrelevant.

@alexeykuzmin alexeykuzmin merged commit b45dc78 into master Oct 5, 2018
@release-clerk
Copy link

release-clerk bot commented Oct 5, 2018

Release Notes Persisted

no notes

@alexeykuzmin alexeykuzmin deleted the fix-zip-symbols branch October 5, 2018 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexeykuzmin @jkleinsc