build: fix native_mksnapshot build #15770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
requested changes
Nov 20, 2018
jkleinsc
force-pushed
the
fix-native-mksnapshot-build
branch
from
c6d7f53
to
4fd0ed2
Compare
BinaryMuse
approved these changes
Nov 20, 2018
|
@jkleinsc Do you think this should go to master and backport to 4-0-x or just land it in 4-0-x? |
|
@BinaryMuse it needs to be backported to 4-0-x |
nornagon
reviewed
Nov 20, 2018
patches/common/v8/do_not_run_arm_arm64_mksnapshot_binaries.patch
Outdated
Show resolved
Hide resolved
When we changed our electron_mksnapshot_zip target to include the v8_context_snapshot_generator, this dependency made the `run_mksnapshot` target run which was trying to run an arm/arm64 binary on x64 hardware. Don't use custom build args for native_mksnapshot as they are not needed
jkleinsc
force-pushed
the
fix-native-mksnapshot-build
branch
from
73d3db4
to
c8fe966
Compare
nornagon
approved these changes
Nov 21, 2018
|
Merging as flaky CI test isn't related to change |
|
No Release Notes |
|
I have automatically backported this PR to "4-0-x", please check out #15799 |
bcpete
pushed a commit
to bcpete/electron
that referenced
this pull request
Apr 18, 2019
* build: fix native_mksnapshot build When we changed our electron_mksnapshot_zip target to include the v8_context_snapshot_generator, this dependency made the `run_mksnapshot` target run which was trying to run an arm/arm64 binary on x64 hardware. Don't use custom build args for native_mksnapshot as they are not needed * Added comment on why snapshot_blob.bin is skipped on arm/arm64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we changed our electron_mksnapshot_zip target to include the v8_context_snapshot_generator, this dependency made the
run_mksnapshottarget run which was trying to run an arm/arm64 binary on x64 hardware. This PR changes our native_mksnapshot build to not try to run that binary.Description of Change
Checklist
npm testpassesRelease Notes
Notes: no-notes