New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electron 4.0 breaks interceptStreamProtocol. #16192
Comments
This is a pretty severe regression on 4.0... a main API should not simply stop working and it shouldn't take weeks to resolve. Is this API not tested? How did the 4.0 release even happen? It makes it hard to commit to Electron when major platform APIs simply don't work. |
Hi @burtonator. We need to have a talk about your approach to the project, and people working on Electron. Open source is tricky, and I understand that relying heavily on a project like Electron can be scary, frustrating, and confusing. We do not want to break anyones apps. None of the maintainers want that. We even run a program to help ensure we fix participating app's major issues during our beta cycle. Despite that, the issue track is not a place for snide, snark, and comments belittling folks working to maintain a gigantic project. Moving forward, I would recommend reading and following the advice in Creators, contributors, and collaborators. Just so we're clear, you are welcome to continue participating in the following ways:
Including additional comments such as "How did the 4.0 release even happen" or "The devs NEED to take this seriously" are off-topic and will result in those issues being closed immediately. Please follow the next step exactly Let's all take a moment to digest the above. Please do not interact with the project for 24-hours. No comments, new issues, or pull-requests. After that, please look through your open issues and edit them to ensure they're entirely on-topic, and we can continue the discussion here about the best way to engage going forward. |
Other discussion aside, I'm closing this as a duplicate of #13519. This is a procedural action & not intended as commentary on the rest of the discussion. |
This comment has been minimized.
This comment has been minimized.
Hey @burtonator, I enjoyed the chance to step back from this issue, but it looks like there was a misunderstanding about your next step. No worries, that's why pencils have erasers. We're going to try this again. I'm asking everyone step back and withdraw from this issue, and others you have posted for the next 7 days. We won't close anything, and you won't post any followup comments, PRs, etc. We can use that time to reflect on how everyone really just wants open source to work, and come back with a fresh perspective. In order to avoid ambiguity or futher miscommunications, I want to make it clear that this is not a suggestion. This is your and everyone elses duty to continue participation in the Electron community. |
I reported this bug on the 3.x series and it was never addressed.
The community had a workaround by calling the callback via setTimeout.
#13519
... but now the workaround is dead in the 4.x.x series.
The devs NEED to take this seriously. This just killed my app and if it's not fixed I might as well shut down the entire project.
I tried to refactor my code to call the callback without setTimeout and that doesn't fix the problem.
Can someone from the Electron team prioritize this or let me know of a way to prioritize this. This is critical for may app...
The text was updated successfully, but these errors were encountered: