Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test for second-instance event parameter #16798

Merged
merged 6 commits into from
Mar 12, 2019
Merged

test: add test for second-instance event parameter #16798

merged 6 commits into from
Mar 12, 2019

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Feb 6, 2019

Notes: no-notes

@nornagon nornagon requested a review from a team February 6, 2019 22:44
nornagon
nornagon commented Feb 23, 2019
View reviewed changes
spec/package.json
@@ -24,6 +24,7 @@
"multiparty": "^4.2.1",
"q": "^1.5.1",
"send": "^0.16.2",
"split": "^1.0.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already depended on this transitively, so no package-lock.json change needed

codebytere
codebytere previously approved these changes Feb 25, 2019
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks like it's dying on

SyntaxError: Unexpected token s in JSON at position 0

@codebytere codebytere dismissed their stale review February 25, 2019 10:54

meant to comment not approve

@codebytere
Copy link
Member

codebytere commented Mar 11, 2019 •
edited

some conflicts and this win failure:

not ok 909 webContents module devtools window can receive and handle menu events
  AssertionError: value should eventually become the pasted value: expected '' to equal 'test value'
      at Context.<anonymous> (C:\projects\src\electron\spec\api-web-contents-spec.js:422:22)

@nornagon
Copy link
Member Author

the win failure is unrelated (& that test was disabled with the 74 merge). i'll rebase though.

@jkleinsc jkleinsc merged commit ea6a926 into master Mar 12, 2019
@release-clerk
Copy link

release-clerk bot commented Mar 12, 2019

No Release Notes

@jkleinsc jkleinsc deleted the single-instance-args-test branch March 12, 2019 15:58
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@nornagon @kiku-jw
test: add test for second-instance event parameter (electron#16798)
2428e2d 
* test: add test for second-instance event parameter

* robustify getting data from child process

* fix test on windows

* fix lint

* Update api-app-spec.js

* fix package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound left review comments

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nornagon @codebytere @jkleinsc @MarshallOfSound