build: remove strip_debug_info gn arg declaration #17306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly and causing release build failures on windows
|
Can we run a release build to test this? |
deepak1556
approved these changes
Mar 9, 2019
There was a problem hiding this comment.
Sounds good to remove android only config. Have verified this change fixes the issue. The issue became visible as a side effect of https://chromium-review.googlesource.com/c/chromium/src/+/1176979
codebytere
approved these changes
Mar 9, 2019
|
No Release Notes |
kiku-jw
pushed a commit
to kiku-jw/electron
that referenced
this pull request
May 16, 2019
…ly and causing release build failures on windows (electron#17306)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is android only and causing release build failures on windows
This is currently causing release build failures on Windows with C74
Notes: no-notes