refactor: use ipcMainUtils.invokeInWebContents / ipcRendererUtils.handle helpers for Chrome APIs #17417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
force-pushed
the
miniak/refactor-chrome-api
branch
5 times, most recently
from
bc70f68
to
f3df95a
Compare
miniak
changed the base branch from
master
to
miniak/invoke-webcontents-validation
miniak
changed the title
miniak
force-pushed
the
miniak/refactor-chrome-api
branch
2 times, most recently
from
e7386c2
to
9572f93
Compare
miniak
force-pushed
the
miniak/invoke-webcontents-validation
branch
from
38515c1
to
8f80e7c
Compare
miniak
force-pushed
the
miniak/refactor-chrome-api
branch
from
9572f93
to
b7c1b0e
Compare
miniak
force-pushed
the
miniak/refactor-chrome-api
branch
4 times, most recently
from
5d5177e
to
a494734
Compare
miniak
changed the base branch from
miniak/invoke-webcontents-validation
to
miniak/fix-chrome-api
miniak
force-pushed
the
miniak/fix-chrome-api
branch
3 times, most recently
from
a946ba0
to
880b214
Compare
miniak
force-pushed
the
miniak/refactor-chrome-api
branch
from
a494734
to
5bf21ee
Compare
miniak
force-pushed
the
miniak/fix-chrome-api
branch
from
880b214
to
7bd2b64
Compare
miniak
force-pushed
the
miniak/refactor-chrome-api
branch
from
5bf21ee
to
b44344e
Compare
miniak
force-pushed
the
miniak/fix-chrome-api
branch
from
7bd2b64
to
5b0cbfe
Compare
miniak
force-pushed
the
miniak/refactor-chrome-api
branch
from
b44344e
to
0af66df
Compare
miniak
force-pushed
the
miniak/fix-chrome-api
branch
2 times, most recently
from
cfadefa
to
2bee62c
Compare
miniak
force-pushed
the
miniak/refactor-chrome-api
branch
from
0af66df
to
40ca8c1
Compare
miniak
force-pushed
the
miniak/refactor-chrome-api
branch
from
40ca8c1
to
21563d1
Compare
…dle helpers for Chrome APIs
miniak
force-pushed
the
miniak/refactor-chrome-api
branch
from
21563d1
to
cdd3971
Compare
|
@samuelmaddock, your full Chromium extension support PR will probably eliminate this code, but I would still like to improve it in the meantime. |
zcbenz
approved these changes
Mar 26, 2019
|
No Release Notes |
There was a problem hiding this comment.
Well, I didn't get to it before @zcbenz, but the changes look clean. 👍
kiku-jw
pushed a commit
to kiku-jw/electron
that referenced
this pull request
May 16, 2019
…dle helpers for Chrome APIs (electron#17417)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Eliminates duplicate code patterns for handling async IPCs with responses. Tests covering the refactored APIs have been added in #17422.
Checklist
npm testpassesRelease Notes
Notes: no-notes