Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade chromium to 76 #17921

Merged
merged 9 commits into from
Apr 29, 2019
Merged

chore: upgrade chromium to 76 #17921

merged 9 commits into from
Apr 29, 2019

Conversation

MarshallOfSound
Copy link
Member

As per @electron/wg-upgrades

Notes: Upgraded Chromium to 76

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 23, 2019
@MarshallOfSound MarshallOfSound added fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases and removed new-pr 🌱 PR opened in the last 24 hours labels Apr 23, 2019
deepak1556
deepak1556 requested changes Apr 26, 2019
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add back the libc++ disabling patch for windows.

@MarshallOfSound MarshallOfSound requested a review from a team as a code owner April 26, 2019 20:24
@deepak1556 @MarshallOfSound
Update atom/common/platform_util_win.cc
0b9bfac 
Co-Authored-By: MarshallOfSound <samuel.r.attard@gmail.com>
@deepak1556
Copy link
Member

76.0.3780.0 seems to be the latest canary, do we want to update here and merge ? Pretty sure there would be api and patch conflicts, I don't want electron-bot to handle it :)

@nornagon
Copy link
Member

I think we should merge this first and then roll forward. I'd rather be on any 76 version in 6-0-x ASAP.

@deepak1556
Copy link
Member

cool, sounds fine.

@nornagon nornagon merged commit f1fa589 into 6-0-x Apr 29, 2019
@release-clerk
Copy link

release-clerk bot commented Apr 29, 2019

Release Notes Persisted

Upgraded Chromium to 76

@nornagon nornagon deleted the chromium-upgrade/76 branch April 29, 2019 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarshallOfSound @deepak1556 @nornagon