ci: generate debug symbols on Linux #18676

CapOM · 2019-06-06T20:04:49Z

Description of Change

For mac and win there is currently electron-v4.2.3-darwin-x64-dsym.zip and electron-v4.2.3-win32-x64-pdb.zip of about 500MB. There is no such debug package for linux. This PR just fixes that.

Electron uses breakpad to generate minidumps but there are cases where it does not work properly on Linux so better to use usual coredumps and proper debug symbols on Linux.

#13315

Checklist

PR description included and stakeholders cc'd
npm test passes
tests are changed or added
relevant documentation is changed or added
PR title follows semantic commit guidelines
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Generate debug symbols on Linux

CapOM · 2019-06-06T21:54:38Z

Yes it has generated the new debug.zip file: https://circleci.com/gh/electron/electron/220774?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link

Failures on Mac and Win seem unrelated to this PR

CapOM · 2019-06-06T21:59:35Z

Hi @alexeykuzmin , Hi @MarshallOfSound , who will be able to review this change ? Thx a lot.

.circleci/config.yml

appveyor.yml

script/strip-binaries.py

script/zip-symbols.py

script/strip-binaries.py

alexeykuzmin · 2019-06-10T18:48:28Z

@CapOM Thank you for the PR! It's definitely something that can be really useful.
I left a few comments in the code though.

jkleinsc

Instead of including this in the strip binaries step/script this should be done in its own step/script that gets executed before strip binaries.

CapOM · 2019-06-26T20:17:24Z

Hi I addressed the remarks, added a separate script, please take a look, thx!

MarshallOfSound

If you want these to be uploaded in the release you'll have to update both the upload.py script and the validate-release script (to check that the assets exist)

CapOM · 2019-06-28T16:20:57Z

Hi @MarshallOfSound , thx for your comment. I pushed what you suggested. Please take a look to script/release/uploaders/upload.py and script/release/release.js.

CapOM · 2019-07-02T16:32:22Z

Hi, gentle ping ?

MarshallOfSound

The change looks reasonable I'd like some thought from @nornagon as they're currently refactoring our symbol generation 👍

nornagon

Seems handy, just a few style comments.

FYI, #19042 refactors some symbol dumping stuff for breakpad symbols, but I don't think it'll conflict with this.

script/copy-debug-symbols.py

.circleci/config.yml

script/lib/config.py

script/copy-debug-symbols.py

CapOM · 2019-07-03T23:12:58Z

Hi @nornagon , thx for the review. I addressed all of your remarks. Please take a look, thx!

nornagon

Real close! Thanks for working on this :)

ping @jkleinsc, can we get a release dry run on this PR?

script/release/uploaders/upload.py

.circleci/config.yml

jkleinsc · 2019-07-15T14:54:57Z

Release builds for this PR here:
CircleCI release build request for linux-arm-publish successful. Check https://circleci.com/gh/electron/electron/261930 for status.
CircleCI release build request for mas-publish successful. Check https://circleci.com/gh/electron/electron/261934 for status.
CircleCI release build request for linux-arm64-publish successful. Check https://circleci.com/gh/electron/electron/261931 for status.
CircleCI release build request for linux-ia32-publish successful. Check https://circleci.com/gh/electron/electron/261935 for status.
CircleCI release build request for linux-x64-publish successful. Check https://circleci.com/gh/electron/electron/261932 for status.
CircleCI release build request for osx-publish successful. Check https://circleci.com/gh/electron/electron/261933 for status.
AppVeyor release build request for electron-x64 successful. Check build status at https://ci.appveyor.com/project/electron-bot/electron-x64-release/build/1.0.113
AppVeyor release build request for electron-ia32 successful. Check build status at https://ci.appveyor.com/project/electron-bot/electron-ia32-release/build/1.0.86

cc @nornagon @CapOM

trop · 2019-11-25T17:17:13Z

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

trop · 2019-11-25T17:28:50Z

@nornagon has manually backported this PR to "8-x-y", please check out #21278

trop · 2019-11-25T17:31:51Z

@nornagon has manually backported this PR to "7-1-x", please check out #21279

trop · 2019-11-25T17:34:41Z

@nornagon has manually backported this PR to "6-1-x", please check out #21280

* ci: generate debug symbols on Linux (#18676) * kick ci

electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 6, 2019

CapOM changed the title ~~Generate debug symbols linux~~ Generate debug symbols on Linux Jun 6, 2019

CapOM changed the title ~~Generate debug symbols on Linux~~ ci: generate debug symbols on Linux Jun 6, 2019

electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 6, 2019

codebytere requested review from jkleinsc and alexeykuzmin June 7, 2019 15:21

alexeykuzmin suggested changes Jun 10, 2019

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

appveyor.yml Outdated Show resolved Hide resolved

script/strip-binaries.py Outdated Show resolved Hide resolved

script/zip-symbols.py Show resolved Hide resolved

script/strip-binaries.py Outdated Show resolved Hide resolved

nornagon mentioned this pull request Jun 10, 2019

Circular loop #18667

Closed

3 tasks

jkleinsc requested changes Jun 17, 2019

View reviewed changes

CapOM force-pushed the generate_debug_symbols_linux branch 2 times, most recently from 40b79a4 to 347ee92 Compare June 26, 2019 20:13

MarshallOfSound reviewed Jun 28, 2019

View reviewed changes

CapOM force-pushed the generate_debug_symbols_linux branch from 347ee92 to f9efe5c Compare June 28, 2019 16:18

CapOM requested a review from a team as a code owner June 28, 2019 16:18

MarshallOfSound reviewed Jul 2, 2019

View reviewed changes

nornagon requested changes Jul 2, 2019

View reviewed changes

CapOM force-pushed the generate_debug_symbols_linux branch from f9efe5c to c0756d6 Compare July 3, 2019 23:10

nornagon requested changes Jul 8, 2019

View reviewed changes

script/release/uploaders/upload.py Show resolved Hide resolved

.circleci/config.yml Outdated Show resolved Hide resolved

CapOM force-pushed the generate_debug_symbols_linux branch 3 times, most recently from 9240529 to 8b99934 Compare July 12, 2019 15:40

CapOM force-pushed the generate_debug_symbols_linux branch from 8b99934 to 276fe5e Compare July 15, 2019 17:26

trop bot added needs-manual-bp/6-1-x and removed target/8-x-y labels Nov 25, 2019

nornagon pushed a commit that referenced this pull request Nov 25, 2019

ci: generate debug symbols on Linux (#18676)

4614f3a

nornagon mentioned this pull request Nov 25, 2019

ci: generate debug symbols on Linux #21278

Merged

trop bot added in-flight/8-x-y and removed needs-manual-bp/8-x-y labels Nov 25, 2019

nornagon pushed a commit that referenced this pull request Nov 25, 2019

ci: generate debug symbols on Linux (#18676)

55bcf62

nornagon mentioned this pull request Nov 25, 2019

ci: generate debug symbols on Linux #21279

Merged

trop bot added in-flight/7-1-x and removed needs-manual-bp/7-1-x labels Nov 25, 2019

nornagon pushed a commit that referenced this pull request Nov 25, 2019

ci: generate debug symbols on Linux (#18676)

bf5ce59

nornagon mentioned this pull request Nov 25, 2019

ci: generate debug symbols on Linux #21280

Merged

trop bot added in-flight/6-1-x and removed needs-manual-bp/6-1-x labels Nov 25, 2019

MarshallOfSound pushed a commit that referenced this pull request Nov 27, 2019

ci: generate debug symbols on Linux (#18676) (#21279)

4cb983e

trop bot added merged/7-1-x and removed in-flight/7-1-x labels Nov 27, 2019

zcbenz pushed a commit that referenced this pull request Nov 27, 2019

ci: generate debug symbols on Linux (#18676) (#21280)

ba2841c

trop bot added merged/6-1-x and removed in-flight/6-1-x labels Nov 27, 2019

jkleinsc pushed a commit that referenced this pull request Dec 3, 2019

ci: generate debug symbols on Linux (#21278)

d48f99f

* ci: generate debug symbols on Linux (#18676) * kick ci

trop bot added merged/8-x-y and removed in-flight/8-x-y labels Dec 3, 2019

sofianguy added this to Fixed in 8.0.0-beta.4 in 8.2.x Dec 9, 2019

sofianguy added this to Fixed in 6.1.6 in 6.1.x Feb 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: generate debug symbols on Linux #18676

ci: generate debug symbols on Linux #18676

CapOM commented Jun 6, 2019 •

edited

CapOM commented Jun 6, 2019

CapOM commented Jun 6, 2019

alexeykuzmin commented Jun 10, 2019

jkleinsc left a comment

CapOM commented Jun 26, 2019

MarshallOfSound left a comment

CapOM commented Jun 28, 2019

CapOM commented Jul 2, 2019

MarshallOfSound left a comment

nornagon left a comment

CapOM commented Jul 3, 2019

nornagon left a comment

jkleinsc commented Jul 15, 2019

trop bot commented Nov 25, 2019

trop bot commented Nov 25, 2019

trop bot commented Nov 25, 2019

trop bot commented Nov 25, 2019

ci: generate debug symbols on Linux #18676

ci: generate debug symbols on Linux #18676

Conversation

CapOM commented Jun 6, 2019 • edited

Description of Change

Checklist

Release Notes

CapOM commented Jun 6, 2019

CapOM commented Jun 6, 2019

alexeykuzmin commented Jun 10, 2019

jkleinsc left a comment

Choose a reason for hiding this comment

CapOM commented Jun 26, 2019

MarshallOfSound left a comment

Choose a reason for hiding this comment

CapOM commented Jun 28, 2019

CapOM commented Jul 2, 2019

MarshallOfSound left a comment

Choose a reason for hiding this comment

nornagon left a comment

Choose a reason for hiding this comment

CapOM commented Jul 3, 2019

nornagon left a comment

Choose a reason for hiding this comment

jkleinsc commented Jul 15, 2019

trop bot commented Nov 25, 2019

trop bot commented Nov 25, 2019

trop bot commented Nov 25, 2019

trop bot commented Nov 25, 2019

CapOM commented Jun 6, 2019 •

edited