Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing headers file for building native code for ElectronJS v3.0.16 #18787

Closed
lissyx opened this issue Jun 14, 2019 · 7 comments
Closed

Missing headers file for building native code for ElectronJS v3.0.16 #18787

lissyx opened this issue Jun 14, 2019 · 7 comments

Comments

@lissyx
Copy link

lissyx commented Jun 14, 2019

Issue Details

  • Electron Version:
    • 3.0.16
  • Operating System:
    • Linux, macOS, Windows
  • Last Known Working Electron version:
    • N/A

Expected Behavior

File at https://atom.io/download/electron/v3.0.16/node-v3.0.16-headers.tar.gz is downloadable

Actual Behavior

node-gyp / node-pre-gyp build fails with 404 on https://atom.io/download/electron/v3.0.16/node-v3.0.16-headers.tar.gz

@lissyx
Copy link
Author

lissyx commented Jun 14, 2019

I could successfully access 4.0.3, 4.1.4, 5.0.0, but anything earlier seems to have disappeared ? I could understand older releases to be cleaned up, but according to https://electronjs.org/releases/stable?version=3&page=3#3.0.16 this one is just three months old.

@lissyx
Copy link
Author

lissyx commented Jun 14, 2019

For context, we do call node-pre-gyp with --target=3.0.16 --disturl=https://atom.io/download/electron --runtime=electron and it was working flawlessly over the past weeks.

@lissyx
Copy link
Author

lissyx commented Jun 14, 2019

e73a0e6

@lissyx
Copy link
Author

lissyx commented Jun 14, 2019

@MarshallOfSound Looks like the URL we were using is deprecated, but even on the new one, I can't find those files: https://electronjs.org/headers/v3.0.16/node-v3.0.16-headers.tar.gz Do you know if that is on-purpose ?

@MarshallOfSound
Copy link
Member

@lissyx Drop back to node-gyp 4.x for now, looks like the latest release of node-gyp (went out today) broke support for Electron < 4.

nodejs/node-gyp#1778

Gonna leave this open just so folks coming to our tracker can find it while node-gyp is fixed.

@lissyx
Copy link
Author

lissyx commented Jun 14, 2019

@MarshallOfSound Sent a PR with new URL and forcing node-gyp@4.x, and it is indeed starting to turn green, thanks for the workaround !

@codebytere
Copy link
Member

Closing as this has been addressed and fixed on the node-gyp end.

@codebytere codebytere removed this from Unsorted Issues in 3.0.x / 3.1.x Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants