Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: auto generate electron_version.h from the version file #18866

Merged
merged 2 commits into from Jun 19, 2019
Merged

refactor: auto generate electron_version.h from the version file #18866

merged 2 commits into from Jun 19, 2019

Conversation

MarshallOfSound
Copy link
Member

Remove another bit of logic from our version bump script, we can auto generate the version header as well.

Notes: no-notes

@MarshallOfSound MarshallOfSound requested a review from a team as a code owner June 18, 2019 18:14
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 18, 2019
@deepak1556
Copy link
Member

Is it possible to reuse build/util/process_version.gni and build/util/version.py ? No hard rule, just want to see if we can avoid some templates.

@MarshallOfSound
Copy link
Member Author

@deepak1556 I looked into build/util/process_version.gni but it did what this templating logic does but more complicated and doesn't let us provide values from semver and doesn't understand prerelease tags 🤷‍♂ Seemed more straightforward to build this templater in our code

@deepak1556
Copy link
Member

ah okay if we couldn't customize it, then not useful. Thanks for looking into it.

nornagon
nornagon requested changes Jun 18, 2019
View reviewed changes
BUILD.gn Outdated Show resolved Hide resolved
build/generate-template.py Outdated Show resolved Hide resolved
build/templates/electron_version.tmpl Outdated Show resolved Hide resolved
build/templates/electron_version.tmpl Show resolved Hide resolved
build/templated_file.gni Outdated Show resolved Hide resolved
BUILD.gn Show resolved Hide resolved
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 19, 2019
nornagon
nornagon reviewed Jun 19, 2019
View reviewed changes
BUILD.gn Outdated Show resolved Hide resolved
@MarshallOfSound @nornagon
Update BUILD.gn
0d8713e 
Co-Authored-By: Jeremy Apthorp <nornagon@nornagon.net>
@MarshallOfSound MarshallOfSound merged commit 7201845 into master Jun 19, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 19, 2019

No Release Notes

@MarshallOfSound MarshallOfSound deleted the auto-generate-version-header branch June 19, 2019 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MarshallOfSound @deepak1556 @nornagon @codebytere