-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix platform location for params #18987
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a change for more consistency, also worth noting that by moving these to here we lose them from the generated type definitions (not a huge issue IMO but worth noting)
9fd6949
to
430a498
Compare
No Release Notes |
/trop run backport-to 6-0-x |
The backport process for this PR has been manually initiated, |
I was unable to backport this PR to "6-0-x" cleanly; |
Description of Change
Most of our argument platform specifiers follow the optionality specifier, so this standardizes those that don't to fit that existing pattern.
cc @deermichel, who brought this to my attention 馃檱鈥嶁檧
Checklist
Release Notes
Notes: none