Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix platform location for params #18987

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Conversation

codebytere
Copy link
Member

Description of Change

Most of our argument platform specifiers follow the optionality specifier, so this standardizes those that don't to fit that existing pattern.

cc @deermichel, who brought this to my attention 馃檱鈥嶁檧

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 馃尡 PR opened in the last 24 hours label Jun 26, 2019
Copy link
Contributor

@deermichel deermichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a change for more consistency, also worth noting that by moving these to here we lose them from the generated type definitions (not a huge issue IMO but worth noting)

docs/api/structures/process-memory-info.md Outdated Show resolved Hide resolved
@electron-cation electron-cation bot removed the new-pr 馃尡 PR opened in the last 24 hours label Jun 27, 2019
@codebytere codebytere merged commit 1a6a16e into master Jun 27, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 27, 2019

No Release Notes

@codebytere codebytere deleted the fix-platform-specificity branch June 27, 2019 21:51
@codebytere
Copy link
Member Author

/trop run backport-to 6-0-x

@trop
Copy link
Contributor

trop bot commented Jun 27, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "6-0-x" here we go! :D

@trop
Copy link
Contributor

trop bot commented Jun 27, 2019

I was unable to backport this PR to "6-0-x" cleanly;
you will need to perform this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants