Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exit non-silently when running as root on Linux #19254

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jul 15, 2019

Backport of #19216

See that PR for details.

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 15, 2019
@trop trop bot added 5-0-x backport This is a backport PR labels Jul 15, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 15, 2019
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deermichel The IsSandboxEnabled method isn't present in 5-0-x. You can add it to this backport.

@jkleinsc jkleinsc merged commit 9b72734 into 5-0-x Jul 15, 2019
@release-clerk
Copy link

release-clerk bot commented Jul 15, 2019

No Release Notes

@jkleinsc jkleinsc deleted the trop/5-0-x-bp-fix-exit-non-silently-when-running-as-root-on-linux-1563201536963 branch July 15, 2019 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5-0-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants