build: move our node fork to our patch system #19292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
commented
Jul 16, 2019
DEPS
Outdated
| @@ -12,7 +12,7 @@ vars = { | |||
| 'chromium_version': | |||
| '73.0.3683.121', | |||
| 'node_version': | |||
| '0a300f60bce0c8f0cb3d846fcb0e1f55f26013ee', | |||
| '7ccfb6a1de3b8b028e556d6ed2dcee3025e311a6', | |||
There was a problem hiding this comment.
We should figure out why this commit (what our node fork was based off) and the node v12.0.0 tag are different 😕
There was a problem hiding this comment.
agreed, but that shouldn't block this change IMO
MarshallOfSound
added
the
fast-track 🚅
This points our node repo at upstream (nodejs/node) and uses the base node tag as the target ref. We then use our existing patch system and patch files to apply our changes on top of node. This unifies how we patch upstream repos and makes our node patches easier to reason, view, understand and most importantly reduce.
MarshallOfSound
force-pushed
the
node-patch-5
branch
from
1303b10
to
3e19e96
Compare
nornagon
approved these changes
Jul 16, 2019
|
No Release Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This points our node repo at upstream (nodejs/node) and uses the base node tag as the target ref. We then use our existing patch system and patch files to apply our changes on top of node. This unifies how we patch upstream repos and makes our node patches easier to reason, view, understand and most importantly reduce.
Notes: no-notes