Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly emit BrowserWindow alwaysOnTop status #19506

Merged
merged 1 commit into from
Jul 30, 2019
Merged

fix: correctly emit BrowserWindow alwaysOnTop status #19506

merged 1 commit into from
Jul 30, 2019

Conversation

codebytere
Copy link
Member

Backport of #19463.

See that PR for more details.

Notes: Fixed inverted alwaysOnTop status returned when always-on-top-changed was emitted.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 29, 2019
@trop trop bot mentioned this pull request Jul 29, 2019
Merged
5 tasks
@codebytere codebytere added 5-0-x backport This is a backport PR labels Jul 29, 2019
@codebytere codebytere requested a review from a team July 29, 2019 18:18
@codebytere codebytere removed the new-pr 🌱 PR opened in the last 24 hours label Jul 29, 2019
deermichel
deermichel approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@deermichel deermichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARM has a bad day - but looks unrelated.

@codebytere codebytere merged commit 4fa89a1 into 5-0-x Jul 30, 2019
@release-clerk
Copy link

release-clerk bot commented Jul 30, 2019

Release Notes Persisted

Fixed inverted alwaysOnTop status returned when always-on-top-changed was emitted.

@codebytere codebytere deleted the always-on-top-fix-5 branch July 30, 2019 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deermichel deermichel deermichel approved these changes

Assignees
No one assigned
Labels
5-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @deermichel