Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix invalid code block language tags #19513

Merged
merged 1 commit into from
Jul 30, 2019
Merged

docs: fix invalid code block language tags #19513

merged 1 commit into from
Jul 30, 2019

Conversation

deermichel
Copy link
Contributor

Description of Change

After updating e/hubdown at e/i18n, the syntax highlighting step of our docs generation fails on text and txt lang tags. The highlighting library seems to got pickier on invalid languages. However, we could use plaintext instead - see supported lang tags.

To avoid touching docs of older versions, we'll add a temporary transformer to e/i18n which replaces text/txt tags with plaintext.

cc @HashimotoYT @codebytere

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 29, 2019
@deermichel deermichel mentioned this pull request Jul 29, 2019
Merged
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 30, 2019
@codebytere codebytere merged commit af33167 into master Jul 30, 2019
@release-clerk
Copy link

release-clerk bot commented Jul 30, 2019

No Release Notes

@codebytere codebytere deleted the intern/docs-plaintext branch July 30, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
documentation 📓
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@deermichel @codebytere @MarshallOfSound