Electron's use of BoringSSL

[willward]

Hi,
in the latest source code it looks like electron_node is built using boringssl instead of openssl directly. I wanted to confirm if my understanding is correct ?

I saw in this issue nodejs/node#25890 there was some discussion about this.

looking at third_party/electron_node/BUILD.gn in the latest source suggests that boringSSL is what's used

if (node_use_openssl) {
    print("node_use_openssl in BUILD.gn")
    deps += [ "//third_party/boringssl" ]
    sources += [
      "src/node_crypto.cc",
      "src/node_crypto.h",
      "src/node_crypto_bio.cc",
      "src/node_crypto_bio.h",
      "src/node_crypto_clienthello-inl.h",
      "src/node_crypto_clienthello.cc",
      "src/node_crypto_clienthello.h",
      "src/node_crypto_groups.h",
      "src/tls_wrap.cc",
      "src/tls_wrap.h",
    ]
    print("deps: ", deps)
    cflags_cc += [ "-Wno-sign-compare" ]
  }

printing our process.versions from an electron app still lists openssl: '1.1.0' but perhaps that is the version of openssl that is wrapped by boringSSL.

[codebytere]

Yes, this is correct. This is a hard requirement of our use of Chromium.

[codebytere]

Yes, this is correct. This is a hard requirement of our use of Chromium.