fix: correctly emplace optional values in the value converter #20985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
approved these changes
Nov 5, 2019
MarshallOfSound
added
the
fast-track 🚅
|
What. The. Hell. |
nornagon
approved these changes
Nov 6, 2019
nornagon
approved these changes
Nov 6, 2019
| return true; | ||
| } | ||
| T converted; | ||
| if (Converter<T>::FromV8(isolate, val, &converted)) { | ||
| if (!Converter<T>::FromV8(isolate, val, &converted)) { | ||
| *out = base::nullopt; |
There was a problem hiding this comment.
it seems like this branch should return false with a failed conversion rather than silently convert to nullopt, but given that this is fixing a much bigger 🤦♂ issue, i'm OK with merging as is.
There was a problem hiding this comment.
It isn't a failed conversion because this is an optional param. If this param fails to convert the optional will be empty and the next arg will use this param.
This emulates expected behavior of optional arguments in the middle of argument lists.
|
Release Notes Persisted
|
|
I have automatically backported this PR to "7-1-x", please check out #21008 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't wanna talk about it....
Fixes #20941
Will follow up with a test for master, we do not need to fix anything in master as the gin converter migration fixed this by accident
Notes: Fixed issue where
app.setAppLogsPathdid not work when you provided a valid path