Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump node to v12.13.1 (master) #21198

Merged
merged 7 commits into from
Dec 18, 2019
Merged

chore: bump node to v12.13.1 (master) #21198

merged 7 commits into from
Dec 18, 2019

Conversation

electron-bot
Copy link
Contributor

Updating Node.js to v12.13.1.

See all changes in v12.13.0..v12.13.1

Notes: Updated Node.js to v12.13.1.

@electron-bot electron-bot requested a review from a team as a code owner November 19, 2019 13:01
@codebytere codebytere self-assigned this Nov 19, 2019
@codebytere codebytere force-pushed the roller/node/master branch 4 times, most recently from 31c97d6 to 796d33f Compare November 21, 2019 18:39
@codebytere codebytere force-pushed the roller/node/master branch 3 times, most recently from 022d599 to 9ebc4f5 Compare December 6, 2019 19:09
@deepak1556
Copy link
Member

> dumpbin /dependents shell_browser_ui_unittests

lists advapi32.dll as delay loaded DLL, makes sense we see this error. As for

> dumpbin /dependents electron

it also has it delay loaded but it has other eager loaded dlls like COMCTL32.dll etc that will load advapi32.dll as transitive dependency, hence it didn't crash.

Unittests are only present to test a particular domain of apis, we don't have to build the entire electron_lib and initialize whole node stuff, things can be bit granular and only depend on the sources it needs, would fix this problem without patch.

@codebytere codebytere force-pushed the roller/node/master branch 4 times, most recently from 12532e8 to 266e125 Compare December 14, 2019 20:19
electron-bot and others added 6 commits December 17, 2019 14:17
disable prepareStackTrack test since Node.js won't handle our case, and disable new es-module tests since it's still flagged and requires flags to run properly
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@codebytere codebytere merged commit 8ffc58b into master Dec 18, 2019
@release-clerk
Copy link

release-clerk bot commented Dec 18, 2019

Release Notes Persisted

Updated Node.js to v12.13.1.

@codebytere codebytere deleted the roller/node/master branch December 18, 2019 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants