fix: restore POST forms that open a new window with target=_blank #21469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore some of the original conversion logic in order to fix target=_blank post form submissions.
nornagon
reviewed
Dec 10, 2019
| @@ -0,0 +1,8 @@ | |||
| <html> | |||
There was a problem hiding this comment.
please put this fixture in spec-main
There was a problem hiding this comment.
Wasn't sure of the convention, since all the other fixtures used in chromium-spec.ts (via fixturesPath) point to spec/. Should I change this one or all of them in chromium-spec.ts? I guess I don't see the value in separating them if there's a chance they'll be used in both.
zcbenz
approved these changes
Dec 11, 2019
|
Release Notes Persisted
|
|
I have automatically backported this PR to "8-x-y", please check out #21474 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix a regression introduced in #20719 that caused HTML form submissions to not actually POST data when using
target=_blank. The original implementation in that PR was inshell/common/native_mate_converters/network_converter.cc. Not sure if the removal of those fields was intentional or an oversight. @zcbenz to advise.Checklist
npm testpassesRelease Notes
Notes: Fixed POST-ing HTML forms with target=_blank.