New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow http-parser NODE_OPTION in packaged apps #21694
Conversation
Release Notes Persisted
|
Can someone please let me know on when this will be released? |
/trop run backport-to 8-x-y,9-x-y |
The backport process for this PR has been manually initiated - |
The backport process for this PR has been manually initiated - |
I was unable to backport this PR to "8-x-y" cleanly; |
I was unable to backport this PR to "9-x-y" cleanly; |
@codebytere has manually backported this PR to "8-x-y", please check out #22539 |
The Releases WG has approved this for backporting to 8-x-y. |
Description of Change
Closes #21693.
Whitelists
--http-parser=parser
for use in packaged apps. As a rule, we only allowNODE_OPTION
s in packaged apps on a case by case basis, but as stated in the above linked issue, Nodev11.5.0
changed the default HTTP parser to one that breaks some use cases (see comment), and so that presents a compelling case for allowing this particular flag.cc @MarshallOfSound @ckerr @zcbenz
Checklist
npm test
passesRelease Notes
Notes: Changed NODE_OPTIONs to allow
--http-parser
to be used in packaged apps.