Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow http-parser NODE_OPTION in packaged apps #21694

Merged
merged 1 commit into from Jan 9, 2020

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jan 7, 2020

Description of Change

Closes #21693.

Whitelists --http-parser=parser for use in packaged apps. As a rule, we only allow NODE_OPTIONs in packaged apps on a case by case basis, but as stated in the above linked issue, Node v11.5.0 changed the default HTTP parser to one that breaks some use cases (see comment), and so that presents a compelling case for allowing this particular flag.

cc @MarshallOfSound @ckerr @zcbenz

Checklist

Release Notes

Notes: Changed NODE_OPTIONs to allow --http-parser to be used in packaged apps.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 7, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 8, 2020
@codebytere codebytere merged commit bb05471 into master Jan 9, 2020
@release-clerk
Copy link

release-clerk bot commented Jan 9, 2020

Release Notes Persisted

Changed NODE_OPTIONs to allow --http-parser to be used in packaged apps.

@natkrish
Copy link

Can someone please let me know on when this will be released?

@codebytere
Copy link
Member Author

/trop run backport-to 8-x-y,9-x-y

@trop
Copy link
Contributor

trop bot commented Mar 4, 2020

The backport process for this PR has been manually initiated -
sending your commits to "8-x-y"!

@trop
Copy link
Contributor

trop bot commented Mar 4, 2020

The backport process for this PR has been manually initiated -
sending your commits to "9-x-y"!

@trop
Copy link
Contributor

trop bot commented Mar 4, 2020

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Mar 4, 2020

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Mar 5, 2020

@codebytere has manually backported this PR to "8-x-y", please check out #22539

@jkleinsc
Copy link
Contributor

jkleinsc commented Mar 6, 2020

The Releases WG has approved this for backporting to 8-x-y.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is no way to set the --http-parser NODE_OPTION in a packaged app
5 participants