Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stream protocols not completing #21759

Merged

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jan 13, 2020

Backport of #21733

See that PR for details.

Notes: Fixed an issue where custom stream protocols would sometimes not complete responses when the data stream ended.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 13, 2020
@trop trop bot requested a review from nornagon January 13, 2020 18:28
@trop trop bot mentioned this pull request Jan 13, 2020
5 tasks
@trop trop bot added 8-x-y backport This is a backport PR labels Jan 13, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 13, 2020
@zcbenz zcbenz merged commit 5a2c451 into 8-x-y Jan 14, 2020
@release-clerk
Copy link

release-clerk bot commented Jan 14, 2020

Release Notes Persisted

Fixed an issue where custom stream protocols would sometimes not complete responses when the data stream ended.

@zcbenz zcbenz deleted the trop/8-x-y-bp-fix-stream-protocols-not-completing-1578940116315 branch January 14, 2020 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants