Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add patch to set the base download URL rather than override it completely #22384

Merged
merged 5 commits into from Feb 26, 2020
Merged

fix: add patch to set the base download URL rather than override it completely #22384

merged 5 commits into from Feb 26, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Feb 25, 2020 •
edited by MarshallOfSound

Backport of #22382

See that PR for details.

Notes: fixed session.setSpellCheckerDictionaryDownloadURL to append the dictionary name at the end of requests instead of requesting the same URL for all dictionaries

@trop trop bot requested a review from a team as a code owner February 25, 2020 22:57
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 25, 2020
@trop trop bot requested a review from MarshallOfSound February 25, 2020 22:57
@trop trop bot mentioned this pull request Feb 25, 2020
Merged
@trop trop bot added 8-x-y backport This is a backport PR labels Feb 25, 2020
@MarshallOfSound MarshallOfSound force-pushed the trop/8-x-y-bp-fix-add-patch-to-set-the-base-download-url-rather-than-override-it-completely-1582671463332 branch from cd29b55 to 8e84ce2 Compare February 25, 2020 22:59
@MarshallOfSound MarshallOfSound merged commit d1ccfea into 8-x-y Feb 26, 2020
@release-clerk
Copy link

release-clerk bot commented Feb 26, 2020

Release Notes Persisted

fixed session.setSpellCheckerDictionaryDownloadURL to append the dictionary name at the end of requests instead of requesting the same URL for all dictionaries

@MarshallOfSound MarshallOfSound deleted the trop/8-x-y-bp-fix-add-patch-to-set-the-base-download-url-rather-than-override-it-completely-1582671463332 branch February 26, 2020 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
8-x-y backport This is a backport PR new-pr 🌱 PR opened in the last 24 hours
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@MarshallOfSound