Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix default_app dimensions #22675

Merged
merged 1 commit into from Mar 16, 2020
Merged

chore: fix default_app dimensions #22675

merged 1 commit into from Mar 16, 2020

Conversation

MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Mar 12, 2020

On master the nightly version tag is too long for the window and causes text wrapping which makes a scrollbar appear. It looks a lot nicer without the scrollbar and everything on one line 馃槃

This also removes the white flash when showing the window by adjusting it to be the same background color as the page 馃憤

Notes: no-notes

@electron-cation electron-cation bot added the new-pr 馃尡 PR opened in the last 24 hours label Mar 12, 2020
@ckerr
Copy link
Member

ckerr commented Mar 12, 2020

the nightly version tag is too long for the window and causes text wrapping

馃槀

Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM

@electron-cation electron-cation bot removed the new-pr 馃尡 PR opened in the last 24 hours label Mar 13, 2020
@zcbenz zcbenz merged commit cd5e390 into master Mar 16, 2020
@release-clerk
Copy link

release-clerk bot commented Mar 16, 2020

No Release Notes

@zcbenz zcbenz deleted the fix-default-app-dimensions branch March 16, 2020 06:28
sentialx pushed a commit to sentialx/electron that referenced this pull request Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants