Label names of special menus 'Services', 'Windows' and 'Help' are hardcoded

[mn4367]

The special menus on OS X are only handled properly if one uses the english names, the comment in the source describes this as a hack. I made another hack ;-) which instead uses the 'sublabel'-property to detect those menus. sublabel seems to do nothing on OS X, so it's maybe a viable solution before a real localization mechanism is available for Electron.

If you like, I'll submit a PR.

[zcbenz]

The sublabel is used on Windows and Linux, so using it as solution doesn't sound a good idea to me, I think we need a new property for that.

[mn4367]

The modification I made is only in code for OSX , so other platforms aren't affected. I have also documented this in the section for building menus on OS X, which already mentions those specal menus.

[mn4367]

Of course if you are using 'Windows' and 'Help' as a label (there is no equivalent for 'Services' on Windows, for example) the this could be a problem, but in my opionion making a multi-platform app always involves creating appropriate menus for each platform separately.

[zcbenz]

The sublabel shows on Windows and Linux, so if you reuse the same menu on different platforms you will see OSX_WINDOW_MENU appearing on Windows and Linux. I agree with you that apps should create different menus for different platforms, but on Electron's side we have to ensure things work when user reuses one menu for all platforms.

Also I think though it is OK to use hacks in implementations, we should not make the API look like a hack.